Add new api for wikipedia image info#29
Open
zexigong wants to merge 8 commits intoWikidocumentaries:masterfrom
Open
Add new api for wikipedia image info#29zexigong wants to merge 8 commits intoWikidocumentaries:masterfrom
zexigong wants to merge 8 commits intoWikidocumentaries:masterfrom
Conversation
Author
Contributor
|
Thank you for this pull request! I wanted to investigate this more myself but I haven't had the time. Perhaps you can answer some of the questions I have:
|
Author
|
Migrated parsing logic to backend, shared code with wikimedia-commons added more fields fixed typo
Author
|
Hi @tuukka, in the new commit
|
… titles and return the corresponding images in the same order; fix the title conversion bug.
This reverts commit 0c10c2e. do not need
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.